-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move icepack to a submodule, and enable icepack in CI #1116
base: develop
Are you sure you want to change the base?
Conversation
@eap there is something weird going on with the CI here. There are 4 instances now of the unit test "running", but the integration test is skipped because "prior step failed". The first CI unit test says it has been "running" for 17.5 hours now. I'm not sure what's going on since I cant look at any of the build output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@travissluka 🎉 you rock! looks good to my non-expert eye. I'm going to build and also check what needs to be done to adapt in gdasapp, I'll be back to approve once ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and I've prepared our workflow for this change. Thank you @travissluka 🎉
pinging @Dooruk in case anything needs to be changed in your build scripts |
Description
Icepack is now a submodule of soca, instead of using a custom fork of the repo in the bundle, the same as what was done for
mom6
. I used version1.2.5
of icepack, which let me compile without changing the soca code. Updating to a newer version (1.5.0 is the latest) is outside the scope of this PRUsing git submodules for this is ok assuming the following conditions remain true:
If any of those are ever false, we should revert back to a fork of the repo.
Other things that were changed:
external/
directory, to tidy things upif(icepack_FOUND)
cmake statements were removed. ice is important, so we now assume that icepack is always available! 🧊 🌊 🐧 ❄️icepack
library built here is namedicepack_limited
because only the files needed by soca are compiled. Keep this in mind if you ever need to use other icepack routines, you might have to enable other files inicepack_files.cmake
After this PR is merged, separate PRs will be issued to remove icepack from the CI and the jedi-bundle, and our icepack fork can be archived.<- nevermind, I forgot icepack was not being used by the CI until now!