Add header, hyperlink and subtext utilities (#6102)
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request adds three new utility functions to the File-Level Changes
Tips
|
BenCos17
merged commit 9a28195
into
JARVIS-discordbot:Cog-Creators-V3/develop
26 of 28 checks passed
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @BenCos17 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| ---------- | ||
| text : str | ||
| The text for the header. | ||
| url : Literal['small', 'medium', 'large'] |
There was a problem hiding this comment.
issue: Incorrect parameter name in docstring
The parameter name in the docstring should be 'size' instead of 'url' to match the function signature.
BenCos17
added a commit
that referenced
this pull request
Sep 1, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434) Co-authored-by: Artemis6969 <[email protected]> * Generate default LL server config and attach it to GH release (Cog-Creators#6430) * [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435) Co-authored-by: Jakub Kuczys <[email protected]> * [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429) * Bump dependencies (Cog-Creators#6436) * Red 3.5.13 - Changelog (Cog-Creators#6437) * Automated Crowdin downstream (Cog-Creators#6439) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.13 (Cog-Creators#6438) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix publish release workflow * Add missing perm to Publish Release workflow * Change Red 3.5.13 release date * Version bump to 3.5.14.dev1 * [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441) * Split out non-Python assets in Publish Release workflow (Cog-Creators#6440) * Add `header`, `hyperlink` and `subtext` utilities (Cog-Creators#6102) (#19) Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]> --------- Co-authored-by: Guyonsteroids <[email protected]> Co-authored-by: Artemis6969 <[email protected]> Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: aikaterna <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mellow <[email protected]> Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Have the changes in this PR been tested?
Yes
Summary by Sourcery
Add new utility functions
header,hyperlink, andsubtextto enhance text formatting capabilities in the chat formatting module.New Features:
hyperlinkutility function to create hyperlink markdown with specified text and URL.headerutility function to format text as a header with specified sizes: small, medium, or large.subtextutility function to format text as subtext.