Object node can return arrays #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a more appropriate type
codemile
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Looks fine to me, but be aware that isArray() has edge cases where it can return false for other types of arrays. For example, Int8Array returns false or objects that are iterators.
We probably want to avoid allowing complex types like that anyway and should stick with simple Array objects.
|
Good to know, I really only care about Array arrays here though I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspect the output type of the object node and if it's an array, return a more-appropriate
object[]type rather thanobject. Fixes #305