fix: Mitigating undefined bug in alreadyOpenedProject.fsPath

[AryamanAgrawalIronclad]

• When using File > Open Project we were encountering an undefined value when trying to parse alreadyOpenedProject.fsPath
• We can mitigate this by placing another check to make sure that the field fsPath exists in alreadyOpenedProject

Error:

[gogwilt]

I think alreadyOpenedPath.fsPath can be undefined, if the project is a new project that hasn't yet been saved.

Perhaps we can move the check into the toast.error call instead?

[AryamanAgrawalIronclad]

If the project hasn't been saved then a user wouldn't be able to use useLoadProjectWithFileBrowser would they? Then it seems fine to have the check here. Not sure if I'm interpreting this right

[AryamanAgrawalIronclad]

Additionally, the purpose of this if condition only wraps the toast, if I move the check within the toast.error, I'd still be dealing with the unwarranted error in loading a project

[gogwilt]

I think my specific suggestion was:

if (alreadyOpenedProject) {
  const fileName = alreadyOpenedProject.fsPath?.split('/').pop() ?? '';
  toast.error(`"${alreadyOpenedProject.project.metadata.title} [${fileName}]" shares the same ID (...`);
  return;
}

[gogwilt]

I guess I'm not sure how we get into this situation in the first place ever, so I'm inclined to suggest programming super defensively.

If alreadyOpenedProject has the same ID as the project we are about to open, we will likely run into issues where the wrong project gets updated in state. Hence why I'd worry about adding the && alreadyOpenedProject.fsPath.

[AryamanAgrawalIronclad]

Gotcha! Thanks for clarifying! That makes sense!

[codemile]

This error is fixed as part of this PR, but silencing undefined error won't fix the underlying issue. The real problem is related to closing/reopening projects that are kept in localStorage.

#293

Anyway, I'm happy to merge this PR and move forward with finishing my PR. It still needs some improvements, but we might as well get rid of this undefined error.

[codemile]

I have resolved the feedback on my PR #293 and if approved can be merged. Thanks for the help @AryamanAgrawalIronclad but this can be closed.

[abrenneke]

Thanks @AryamanAgrawalIronclad I've merged the other PR which fixes the root problem!

[AryamanAgrawalIronclad]

Sounds good! Thanks for finding the right solve!