io-sim and io-sim-classes changes towards publication on Hackage #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
added
io-sim
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
4 times, most recently
from
136f7bc to
9088c6b
Compare
mrBliss
reviewed
Sep 4, 2020
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
from
9088c6b to
ddccb17
Compare
That's not finished yet, anyway thanks for proof reading. |
You're welcome. It's one of my pet peeves 🙂. |
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
from
6c2ca96 to
162fe7d
Compare
|
This is massive enough for a review. |
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
5 times, most recently
from
e4e09cf to
5ae2f24
Compare
mrBliss
reviewed
Sep 4, 2020
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
from
c818efa to
c1ee15a
Compare
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
from
c1ee15a to
af1e821
Compare
|
Related to input-output-hk/io-sim#29 |
dcoutts
approved these changes
Oct 2, 2020
Comment on lines
+26
to
+27
| `io-sim` supports both `io-sim-classes` class hierarchy and `base` | ||
| / `exceptions` class hierarchies (they diverge in some detail). |
There was a problem hiding this comment.
It implements both class hierarchies.
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
from
af1e821 to
2d88e62
Compare
That's more consistent with the library name. 'SimM' is exported as a type alias with a warning attached.
Just to be consistent with `IOSim`.
Split the internal implementation from top level interface.
Ordered authors alphabetically, updated copyright notice.
Drop in replacments for similarly named 'stm' functions.
Use traceEventIO, traceMarkerIO name (as in base).
Use forkIO and forkIOWithUnmask, as in `base` package.
Links to hackage will obiously not work at this point.
This forces us to depend on `stm-2.5.0.0`. We also bump version of `io-sim` - this is probably the cheapest way to support both `stm-2.5` and `stm-2.4` (supported by `io-sim-classes-0.1.0.0` and `io-sim-0.1.0.0`).
Using the provided `lengthTBQueue`.
We now depend on `stm-2.5.0.0`.
New names: * newTVarIO * newTMVarIO * newTMVarIODefault * newEmptyTMVarIO * newEmptyTMVarIODefault
Use `MonadSTM.Strict.stateTVar` instead.
It's failing to frequently.
coot
force-pushed
the
coot/io-sim-and-io-sim-classes
branch
from
2d88e62 to
40264bd
Compare
|
bors merge |
|
Build succeeded: |
coot
added a commit
that referenced
this pull request
May 16, 2022
2580: io-sim and io-sim-classes changes towards publication on Hackage r=coot a=coot 2662: Split ipv4 and ipv6 addresses in `DiffusionArguments` r=coot a=coot This patch cherry-picks a change from `coot/connection-manager` branch. In that branch we can go even further and remove `getInitiatorLocalAddresses`. Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.