Make it build with ghc 9.12 #1406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed. GHC has been deriving this typeclass for some time and ghc-9.12 now warns about it being redundant.
erikd
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
erikd
force-pushed
the
erikd/ghc-9.12
branch
2 times, most recently
from
b9dd4f4 to
0c19547
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
2 times, most recently
from
7a46308 to
e5fad05
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
from
d7e36b3 to
226d273
Compare
jasagredo
reviewed
Feb 28, 2025
nfrisby
reviewed
Feb 28, 2025
| @@ -16,7 +16,7 @@ | |||
| inputs.hackage.follows = "hackageNix"; | |||
| }; | |||
| hackageNix = { | |||
| url = "github:input-output-hk/hackage.nix"; | |||
There was a problem hiding this comment.
I'm not familiar with the broader consequences of this change. The haskell.nix repo says:
The for-stackage branch also contains all cabal expressions from hackage.org as nix expressions.
This branch is used when working with stack projects in haskell.nix.
Could you summarize the potential reasons to not use it? And what is requiring its use here? The Consensus build process (eg CI) generally doesn't involve stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it build with ghc 9.12
Also note that: