KES Agent Connectivity #1402
Draft
KES Agent Connectivity #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
reviewed
Feb 21, 2025
| @@ -150,6 +150,7 @@ library | |||
| crypton, | |||
| deepseq, | |||
| formatting >=6.3 && <7.3, | |||
| kes-agent, | |||
There was a problem hiding this comment.
This dependency cannot work as is, because it builds socket-unix which won't fly on Windows.
Comment on lines
291
to
292
| keyThreadAsync <- async | ||
| (keyThread set) |
There was a problem hiding this comment.
Do label this thread. This is mandatory in my opinion, see IntersectMBO/cardano-node#6086
| @@ -262,20 +265,38 @@ data PraosCanBeLeader c = PraosCanBeLeader | |||
|
|
|||
| data PraosCredentialsSource c | |||
| = PraosCredentialsUnsound (OCert.OCert c) (KES.UnsoundPureSignKeyKES (KES c)) | |||
| | PraosCredentialsAgent FilePath | |||
There was a problem hiding this comment.
I'm unsure if this one should use FsPath instead? cc @jorisdral
This reverts commit e1a177e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds KES Agent connectivity to consensus.
To use a KES Agent to source KES SignKeys and OpCerts, the
praosCredentialsSourcein thePraosCanBeLeaderdata structure can now be pointed to a domain socket address where it will look for a KES Agent.