Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tallying of votes to the "Motion of no confidence" test #5870

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented May 31, 2024

Description

This PR, slightly modifies the Motion of no confidence test to:

  • Tally the votes after submitting the motion of no confidence
  • Changes two of the votes so that there are some negative votes

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas self-assigned this May 31, 2024
@palas palas requested a review from a team as a code owner May 31, 2024 15:28
@palas palas linked an issue May 31, 2024 that may be closed by this pull request
@palas palas mentioned this pull request May 31, 2024
@palas palas force-pushed the add-tallying-to-no-confidence-test branch from bdd4366 to 87a4ce1 Compare May 31, 2024 19:25
@palas palas added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit 6c3a95a Jun 3, 2024
25 checks passed
@palas palas deleted the add-tallying-to-no-confidence-test branch June 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPO Voting
2 participants