Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Churn counters fix #5864

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Churn counters fix #5864

merged 1 commit into from
Jun 6, 2024

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented May 29, 2024

Description

This pull request addresses a fix for the churn counter in our current tracing implementation. With the new tracing infrastructure, it is necessary to declare new tracers in three separate locations. This redundancy is less than ideal and has been identified as an area for future improvement.

Key Changes

  • Churn Counter Adjustment: Updated the churn counter logic to ensure proper functionality within the new tracing setup.
  • Tracer Declarations: Added the necessary tracer declarations in all three required places to align with the current implementation requirements.

Context and Future Work

The current state of our tracing system is transitional. The new tracing functionality operates behind the legacy interface, which imposes certain restrictions and necessitates the multiple declarations. This approach, while functional, is not optimal. It is our goal to streamline this process once we can fully transition away from the old tracing infrastructure.

Impact

  • Ensures the churn counter works correctly with the new tracing setup.
  • Maintains compatibility with the existing tracing interface.

Next Steps

  • Refactoring: Plan for a refactor to remove the old tracing infrastructure.
  • Streamlining Tracer Declarations: Simplify tracer declarations to avoid redundancy and improve maintainability.

We appreciate any feedback on this fix and suggestions for improving our tracing system as we move forward.

Testing

  • Verified that the churn counter operates correctly with the new tracer declarations.
  • Conducted regression tests to ensure no adverse effects on existing tracing functionality.

@jutaro jutaro requested a review from a team as a code owner May 29, 2024 11:06
@jutaro jutaro self-assigned this May 29, 2024
@jutaro jutaro requested a review from coot May 29, 2024 11:06
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jutaro jutaro force-pushed the jutaro/new_tracer_fix branch from 0b31b30 to e529473 Compare June 3, 2024 09:20
@mgmeier mgmeier added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@mgmeier mgmeier added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@jutaro jutaro added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@carbolymer carbolymer merged commit b4826bf into master Jun 6, 2024
25 checks passed
@carbolymer carbolymer deleted the jutaro/new_tracer_fix branch June 6, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants