Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce protocol version 8 if "ConwayGenesisFile" is not set in node configuration #5858

Merged
merged 1 commit into from
May 29, 2024

Conversation

Jimbo4350
Copy link
Contributor

Description

In order to avoid an accidental hardfork, when "ConwayGenesisFile" is not set in the node configuration file, by default the node can only understand protocol version 8 (Babbage era).

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 requested a review from a team as a code owner May 28, 2024 12:46
@Jimbo4350 Jimbo4350 force-pushed the jordan/enforce-pv8-if-no-conway-genesis-set branch from 282d594 to d8937a9 Compare May 28, 2024 18:45
@carbolymer carbolymer force-pushed the jordan/enforce-pv8-if-no-conway-genesis-set branch 2 times, most recently from 868dde1 to 7336af2 Compare May 29, 2024 09:53
Implement readGenesisMaybe to handle the case where the
ConwayGenesisFile key is not specified in the node configuration.
When "ConwayGenesisFile" is not specified in the node configuration we
use a default empty conway genesis and keep the maximum understooof
protocol version to version 8 (Babbage).
@carbolymer carbolymer force-pushed the jordan/enforce-pv8-if-no-conway-genesis-set branch from 7336af2 to 1de327d Compare May 29, 2024 13:28
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue May 29, 2024
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request May 29, 2024
@carbolymer carbolymer merged commit cb60b94 into master May 29, 2024
24 checks passed
@carbolymer carbolymer deleted the jordan/enforce-pv8-if-no-conway-genesis-set branch May 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants