Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: PlutusV3 BLST workload; DRep injection; UTxO-HD tracing config #5851

Merged
merged 21 commits into from
May 29, 2024

Conversation

mgmeier
Copy link
Contributor

@mgmeier mgmeier commented May 22, 2024

Description

This PR contains work on the performance workbench + benchmark tooling, as well as several new workloads.

New features:

  • PlutusV3 BLST benchmarking script; as well as local + Nomad cloud profiles for it
  • PlutusV3 cost model support
  • DRep injection profiles
  • UTxO-HD tracing config to harmonize log line rates
  • Updated PlutusV2 SECP workloads - and port them to Nomad cluster
  • New/updated Loop2024 Plutus workload

Improvements:

  • tx-generator: fee estimate in plutus-budget-summary.json
  • workbench profile cleanups
  • gen-plutus: list command on CLI
  • tx-generator-apitest: various improvements for development of new Plutus workloads
  • fixes and improvements: workbench; tx-generator; locli

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@mgmeier mgmeier changed the title Bench master bench: PlutusV3 BLST workload; DRep injection; UTxO-HD tracing config May 22, 2024
@mgmeier mgmeier force-pushed the bench-master branch 4 times, most recently from 1567e87 to 4ad5fb7 Compare May 23, 2024 12:26
@mgmeier mgmeier marked this pull request as ready for review May 28, 2024 09:50
@mgmeier mgmeier requested review from a team as code owners May 28, 2024 09:50
@mgmeier mgmeier requested a review from a team as a code owner May 28, 2024 09:50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list option is great! It makes it more of a user-friendly utility.

Copy link
Contributor

@fmaste fmaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgmeier mgmeier added this pull request to the merge queue May 28, 2024
Copy link
Contributor

@NadiaYvette NadiaYvette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the DRep stuff ends up being very little more than profile entries. The plutus-scripts-bench material looks good esp. the new option for gen-plutus.hs.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@mgmeier mgmeier added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 29, 2024
@disassembler disassembler merged commit d678d64 into master May 29, 2024
24 checks passed
@disassembler disassembler deleted the bench-master branch May 29, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants