Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Reorganize testnet CLI functions #5840

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 13, 2024

Description

This PR does not change any functions' bodies. The functions were only moved around and the modules were renamed.
Suggestion: The most efficient review process would be reviewing only modules' exports, how they changed.

cardano-testnet modules dependencies

Before:

before

After

after

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/refactor/reorganize-testnet-cli-functions branch 2 times, most recently from adac327 to 521e2a2 Compare May 13, 2024 16:50
@carbolymer carbolymer marked this pull request as ready for review May 13, 2024 17:01
@carbolymer carbolymer requested a review from a team as a code owner May 13, 2024 17:01
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quality of life improvement 👍

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Much needed organization 👍

@carbolymer carbolymer force-pushed the mgalazyn/refactor/reorganize-testnet-cli-functions branch from 521e2a2 to 16c7b58 Compare May 13, 2024 21:45
@carbolymer carbolymer enabled auto-merge May 13, 2024 21:48
@carbolymer carbolymer force-pushed the mgalazyn/refactor/reorganize-testnet-cli-functions branch from 16c7b58 to 0d5d0a5 Compare May 13, 2024 23:19
@carbolymer carbolymer force-pushed the mgalazyn/refactor/reorganize-testnet-cli-functions branch from 0d5d0a5 to bde2df6 Compare May 14, 2024 08:30
@carbolymer carbolymer disabled auto-merge May 14, 2024 09:33
@carbolymer carbolymer merged commit fe33c2e into master May 14, 2024
19 of 22 checks passed
@carbolymer carbolymer deleted the mgalazyn/refactor/reorganize-testnet-cli-functions branch May 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants