Integrations for node-8.11.0 release
#5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
4 times, most recently
from
9f7e6cd to
419c362
Compare
disassembler
force-pushed
the
lucsanszky/integration-8.11
branch
from
4be474a to
1658c6d
Compare
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
12 times, most recently
from
0235c87 to
ffda6fb
Compare
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
3 times, most recently
from
0ea9935 to
ee158ad
Compare
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
from
88417bc to
808830c
Compare
smelc
approved these changes
May 15, 2024
Jimbo4350
requested changes
May 15, 2024
carbolymer
reviewed
May 15, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/CommitteeAddNew.hs
Outdated
Show resolved
Hide resolved
carbolymer
force-pushed
the
lucsanszky/integration-8.11
branch
from
2fed1d8 to
0eee585
Compare
carbolymer
reviewed
May 15, 2024
carbolymer
approved these changes
May 15, 2024
There was a problem hiding this comment.
I've fixed changes from my and @Jimbo4350's remarks. Tracing changes look ok for me, but it would be better to get a confirmation from Performance & Tracing team.
Everything else LGTM!
|
@Lucsanszky can you squash relevant commits together, please? |
* Fix the type of `flattenCostModel` Type of the parameter of `CostModel` was changed from `Integer` to `Int64` by: IntersectMBO/cardano-ledger@7c59e3a * Change `fromList` to `unsafeFromList` `fromList` was deprecated by: IntersectMBO/plutus@5879f8e * Add tracing instances for `ConwayUtxoPredFailure` `ConwayUtxoPredFailure` is now different from the one in `Babbage` and thus it needed separate instances. See: IntersectMBO/cardano-ledger@e114203 * Fix `Conway` predicate failure instances The bootstrap phase introduced some constructors that are now matched: IntersectMBO/cardano-ledger@6c5d1e0 * Add `HardForkSpecificNodeToClientVersion3` * Initialise `ucppPlutusV3CostModel` The `PlutusV3` cost model was added to `UpgradeConwayPParams` by: IntersectMBO/cardano-ledger@57bb4c1 * Remove `AlonzoGenErrCostModels` Since `CostModelError` can now be removed due to the fact that `cardano-ledger` turns this into a decoder error, it doesn't make sense to keep this around. See: IntersectMBO/cardano-ledger@e173cf2
* Account for `OpenedVolatileDB` change The slot number was added as a parameter by: IntersectMBO/ouroboros-consensus@cbfbd69 * Account for `ShelleyUpdatedProtocolUpdates` rename It was renamed to `ShelleyUpdatedPParams` by: IntersectMBO/ouroboros-consensus@18f186d * Account for `ChainSync` client improvements See: IntersectMBO/ouroboros-consensus@bf3f09a * Limit on eagerness for `ChainDB`: IntersectMBO/ouroboros-consensus@6f7793c * Tweak volatile DB tracers: IntersectMBO/ouroboros-consensus@cbfbd69 * Skip haddocks with 8.10
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
from
d327d69 to
b1d33e8
Compare
Done. Let me know if this is better now. |
palas
reviewed
May 15, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.