Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DRep retirement in an integration test #5574

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Dec 14, 2023

Description

This PR adds an integration test that deregistering a DRep has the desired effect on the ledger state.

This new tests runs approximately in 55 seconds and does not use foldBlocks, but uses checkLedgerStateCondition instead 💪

Context

Fixes #5596

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added
  • NA Any changes are noted in the CHANGELOG.md for affected package
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/test-drep-retirement branch 3 times, most recently from e1edbe7 to bd00785 Compare December 19, 2023 10:17
@smelc smelc marked this pull request as draft December 19, 2023 13:19
@smelc
Copy link
Contributor Author

smelc commented Dec 19, 2023

Convert to draft, as we want to use a ledger event instead of a timeout, as agreed today during the team's weekly. The event needs to be added to cardano-ledger.

@smelc smelc force-pushed the smelc/test-drep-retirement branch 2 times, most recently from 98561b4 to 995ddf7 Compare December 20, 2023 16:20
@smelc smelc force-pushed the smelc/test-drep-retirement branch from 995ddf7 to d2bdda0 Compare January 2, 2024 13:32
@smelc smelc force-pushed the smelc/test-drep-retirement branch from d2bdda0 to 700d359 Compare January 12, 2024 14:07
@smelc smelc force-pushed the smelc/test-drep-retirement branch 2 times, most recently from d3a2a6d to d5ef05f Compare February 9, 2024 09:49
@smelc
Copy link
Contributor Author

smelc commented Feb 12, 2024

Reminder to myself: use #5664 when it's merged to read the drep-state.

@smelc smelc force-pushed the smelc/test-drep-retirement branch 9 times, most recently from c58434f to a9fe066 Compare February 14, 2024 15:59
@smelc smelc marked this pull request as ready for review February 14, 2024 16:06
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couple comments.

@smelc smelc force-pushed the smelc/test-drep-retirement branch 2 times, most recently from 2b99562 to 6e5f51d Compare February 19, 2024 15:49
@smelc smelc enabled auto-merge February 19, 2024 15:49
@smelc smelc force-pushed the smelc/test-drep-retirement branch 2 times, most recently from d79c0d6 to 8ee5885 Compare February 20, 2024 15:59
@smelc smelc force-pushed the smelc/test-drep-retirement branch from 8ee5885 to f90fb0f Compare February 21, 2024 10:34
@carbolymer carbolymer disabled auto-merge February 21, 2024 13:40
@carbolymer carbolymer merged commit 31a1a7d into master Feb 21, 2024
15 of 18 checks passed
@carbolymer carbolymer deleted the smelc/test-drep-retirement branch February 21, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRep Registration/DeRegistration
3 participants