-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DRep retirement in an integration test #5574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1edbe7
to
bd00785
Compare
Convert to draft, as we want to use a ledger event instead of a timeout, as agreed today during the team's weekly. The event needs to be added to |
98561b4
to
995ddf7
Compare
995ddf7
to
d2bdda0
Compare
d2bdda0
to
700d359
Compare
d3a2a6d
to
d5ef05f
Compare
Reminder to myself: use #5664 when it's merged to read the |
c58434f
to
a9fe066
Compare
Jimbo4350
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Couple comments.
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
a9fe066
to
0753b9e
Compare
carbolymer
reviewed
Feb 16, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
carbolymer
reviewed
Feb 16, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
carbolymer
approved these changes
Feb 16, 2024
2b99562
to
6e5f51d
Compare
d79c0d6
to
8ee5885
Compare
Signed-off-by: Clément Hurlin <[email protected]>
Signed-off-by: Clément Hurlin <[email protected]>
Signed-off-by: Clément Hurlin <[email protected]>
Signed-off-by: Clément Hurlin <[email protected]>
8ee5885
to
f90fb0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an integration test that deregistering a DRep has the desired effect on the ledger state.
This new tests runs approximately in 55 seconds and does not use
foldBlocks
, but usescheckLedgerStateCondition
instead 💪Context
Fixes #5596
Checklist
CHANGELOG.md
for affected package.cabal
files are updated