Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from cryptonite library to crypton #4859

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Switch from cryptonite library to crypton #4859

merged 2 commits into from
Jan 29, 2025

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jan 28, 2025

Description

Former has been deprecated in favor of the later.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Sorry, something went wrong.

@erikd erikd requested a review from a team as a code owner January 28, 2025 23:07
Former is deprecated in favor of the later which is supposed to be
a drop in replacement.
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you!

@erikd erikd force-pushed the erikd/crypton branch 2 times, most recently from 3263a63 to f6f07d2 Compare January 29, 2025 00:10
@lehins lehins enabled auto-merge (squash) January 29, 2025 00:12
@lehins lehins merged commit 4b2721c into master Jan 29, 2025
151 of 156 checks passed
@lehins lehins deleted the erikd/crypton branch January 29, 2025 02:21
aniketd added a commit to IntersectMBO/cardano-api that referenced this pull request Feb 25, 2025
`crypton` is the new drop-in replacement to `cryptonite`. We have
switched already in `ledger`[1]. `cryptonite` is no longer maintained.

References:
[1]: IntersectMBO/cardano-ledger#4859
aniketd added a commit to IntersectMBO/cardano-api that referenced this pull request Feb 25, 2025
`crypton` is the new drop-in replacement to `cryptonite`. We have
switched already in `ledger`[1]. `cryptonite` is no longer maintained.

References:
[1]: IntersectMBO/cardano-ledger#4859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants