-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the structure of the GenT monad, to better track explanations. #4838
Conversation
da6f6e2
to
1949778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few preliminary comments
1949778
to
859474b
Compare
859474b
to
579d470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I don't fully understand the change to GenT and why it is necessary it looks like a very nice cleanup and improvement, especially to GE
type.
I'll take a closer look at some point into how GenT is being used to convince myself that it is indeed the way it suppose to be.
579d470
to
b8e2ca6
Compare
Defined pickAll the basis of sums with fixed length. Added getSizedList as a method of the Foldy class getSizeList cost is metered at 1000 calls. Typical calls are less than 10. Gave HasSpec (optional) method 'typeSpecHasError' a better default value
11819da
to
5bdb6a9
Compare
5bdb6a9
to
84671a0
Compare
Finally |
The GenT monad is now a reader of not just Mode, but of both Mode and [NE.NonEmpty String]
The GE monad constructors types have changed
from
To
In addition to these changes in the module Constrained.GenT, several other modules have had their error messages slightly changed so that they display better using the new monad
Checklist
CHANGELOG.md
files updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
updated (usescripts/gen-hie.sh
)