Made divisions that are supposed to fail on zero fail again

IntersectMBO · Jan 27, 2025 · ffc46e9 · ffc46e9
1 parent 28a4903
commit ffc46e9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/eras/shelley/impl/src/Cardano/Ledger/Shelley/Rewards.hs b/eras/shelley/impl/src/Cardano/Ledger/Shelley/Rewards.hs
@@ -66,6 +66,7 @@ import Lens.Micro ((^.))
 import NoThunks.Class (NoThunks (..))
 import Numeric.Natural (Natural)
 import Quiet
+import Data.Ratio ((%))
 
 -- | StakeShare type
 newtype StakeShare = StakeShare {unStakeShare :: Rational}
@@ -289,7 +290,9 @@ rewardOnePoolMember
       pool = poolPs rewardInfo
       sigma = poolRelativeStake rewardInfo
       poolR = poolPot rewardInfo
-      stakeShare = StakeShare $ c %? unCoin totalStake
+      -- warning: totalStake could be zero!
+      stakeShare =
+        StakeShare $ c % unCoin totalStake
       r = memberRew poolR pool stakeShare sigma
 
 -- | Calculate single stake pool specific values for the reward computation.
@@ -332,7 +335,8 @@ mkPoolRewardInfo
     -- intermediate values needed for the individual reward calculations.
     Just blocksN ->
       let Coin pledge = ppPledge pool
-          pledgeRelative = pledge %? unCoin totalStake
+          -- warning: totalStake could be zero!
+          pledgeRelative = pledge % unCoin totalStake
           sigmaA = pstakeTot %? unCoin activeStake
           Coin maxP =
             if pledge <= ostake