Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross reference of files between test suites. #1055

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 5, 2025

Changelog

- description: |
    Remove cross reference of files between test suites
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

There was a data race in CI: sometimes golden files referenced as an input in one test were not yet created in the other test, which was causing spontaneous failures in CI.

This PR copies those golden input files to the respective project's input directory.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer enabled auto-merge February 5, 2025 10:33
@carbolymer carbolymer added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit 6f5b300 Feb 5, 2025
27 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/fix-data-race-in-ci-tests branch February 5, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants