Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix costs calculation for transaction with more than one certificates with the same stake credential and script witness #1028

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 22, 2025

Changelog

- description: |
    Fix costs calculation for transaction with more than one certificates with the same stake credential and script witness.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes:

Requires:

Tested in:

Regression tests executed in:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer changed the title Use correct representation of witnesses in certificates Fix costs calculation for transaction with more than one certificates with the same stake credential and script witness Jan 24, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/correct-certificates-representation branch from b9ffec6 to bc73b71 Compare January 24, 2025 14:32
@carbolymer carbolymer marked this pull request as ready for review January 24, 2025 14:34
@carbolymer carbolymer self-assigned this Jan 29, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/correct-certificates-representation branch 5 times, most recently from 48a74d3 to 7b02cd7 Compare February 3, 2025 16:19
@carbolymer carbolymer enabled auto-merge February 3, 2025 16:20
@carbolymer carbolymer force-pushed the mgalazyn/fix/correct-certificates-representation branch from 7b02cd7 to 1fc22fe Compare February 3, 2025 16:22
@carbolymer carbolymer requested review from a team as code owners February 3, 2025 16:22
…more than one certificates with the same stake credential and script witness.
@carbolymer carbolymer force-pushed the mgalazyn/fix/correct-certificates-representation branch from 1fc22fe to 5d71284 Compare February 3, 2025 16:26
@carbolymer carbolymer added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 3, 2025
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2025
@CarlosLopezDeLara CarlosLopezDeLara merged commit 867b295 into master Feb 4, 2025
25 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the mgalazyn/fix/correct-certificates-representation branch February 4, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build command calculates insufficient Plutus script cost for two certificates
3 participants