Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of script witness files in voting scripts #1027

Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jan 22, 2025

Changelog

- description: |
   Remove use of ScriptWitnessFiles in voting scripts
  type:
    - refactoring    # QoL changes

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-use-of-ScriptWitnessFiles-in-voting-scripts branch 2 times, most recently from 703d3e1 to 7f29e2f Compare January 31, 2025 17:43
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-use-of-ScriptWitnessFiles-in-voting-scripts branch 6 times, most recently from b4008ab to f689ecc Compare January 31, 2025 18:36
@Jimbo4350 Jimbo4350 marked this pull request as ready for review January 31, 2025 18:38
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-use-of-ScriptWitnessFiles-in-voting-scripts branch 2 times, most recently from 0ac6986 to 4ac423b Compare February 3, 2025 15:43
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-use-of-ScriptWitnessFiles-in-voting-scripts branch from 4ac423b to 4670deb Compare February 4, 2025 14:43
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2025
@Jimbo4350 Jimbo4350 merged commit a30e3aa into master Feb 4, 2025
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/remove-use-of-ScriptWitnessFiles-in-voting-scripts branch February 4, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants