Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing gov action on balance transaction #765

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

palas
Copy link
Contributor

@palas palas commented Feb 26, 2025

Changelog

- description: |
    Fixed a bug that caused balancing algorithm to drop unwitnessed government actions
  type:
  - bugfix

Context

This PR:

How to trust this PR

Check the test. You can verify that it fails if applied before the fix.
Check that the code style is correct, that the changes make sense, and the new code doesn't introduce any new bugs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the bug Something isn't working label Feb 26, 2025
@palas palas self-assigned this Feb 26, 2025
@palas palas requested a review from disassembler as a code owner February 26, 2025 14:17
Comment on lines +1558 to +1559
map (,Nothing) unwitnessedTxpp
<> (second Just <$> substitutedExecutionUnits)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the order of proposals: unwitnessed proposals are placed before witnessed ones. I am only aware about script indexing relying on the order (which should be ok after your change) but I don't know if it's not breaking any other hidden ledger invariants about proposals.

Let's be on the safer side and don't change the order of the proposals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Governance actions silently stripped from transaction
2 participants