-
Notifications
You must be signed in to change notification settings - Fork 459
[HEVCd] Added HDR SEI info parsing for HEVC decoding #2726
Conversation
mfxExtMasteringDisplayColourVolume* dispaly_colour = (mfxExtMasteringDisplayColourVolume*)GetExtendedBuffer(surface_out->Data.ExtParam, surface_out->Data.NumExtParam, MFX_EXTBUFF_MASTERING_DISPLAY_COLOUR_VOLUME); | ||
if (pFrame->m_mastering_display.payLoadSize != 0) | ||
{ | ||
if (dispaly_colour && pFrame->m_mastering_display.payLoadSize > 0) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIU HDR SEI might be present not on each frame. If so, what is the expectation here: shall decoder repeat previous SEI HDR info ? It may require ARB discussion.
- @dgurulev for his input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, the related ExtBuffer will use the default value 0
for the frame not include HDR SEI. And can do modify according to the ARB discussion
Hi, what happened to this PR? It doesn't look like there would be any showstopping reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need to decide if we need to update manual, especially for VPL. I'll ping Igor.
For #2597
Attach the MFX_EXTBUFF_MASTERING_DISPLAY_COLOUR_VOLUME and MFX_EXTBUFF_CONTENT_LIGHT_LEVEL_INFO to outputSurface when you need this info for HEVC HDR transfer.