[avce] Expand zero ROI to minimum supported size

[dmitryermilov]

Fixes: #2013

Signed-off-by: Dmitry Ermilov [email protected]

[dmitryermilov]

@lakulako , @saosipov , could you review?

[lakulako]

May be put this check to CheckAndFixOpenRectQueryLike?

[dmitryermilov]

May be put this check to CheckAndFixOpenRectQueryLike?

@lakulako , I did it at first. But then I noticed that the same CheckAndFixOpenRectQueryLike is called from run-time part (

MediaSDK/_studio/mfx_lib/encode_hw/h264/src/mfx_h264_encode_hw_utils_new.cpp

Line 2345 in 0765c10

mfxStatus sts = CheckAndFixRoiQueryLike(video, &task_roi, extRoiRuntime->ROIMode);

).
So moved new condition outside.

[lakulako]

Shouldn't Init behave the same?

[dmitryermilov]

Shouldn't Init behave the same?

I assume while for Query zero values (like no values) makes sense, for processing part zero values are useless, rather invalid.

[dmitryermilov]

BTW, let's align HEVC and AVC here. Actually I thought HEVC behaved as I described above but now I'm not sure:). @yskuridi , could you say how after your ROI change HEVC behaves:

• does it accept zero ROI values at Init and modifies them internally to min supported ROI rects (like Query does)

• or at Init zero rect values are considered as errors (or simply ignored )?

[yskuridi]

• does it accept zero ROI values at Init and modifies them internally to min supported ROI rects (like Query does)

Yes.

[dmitryermilov]

• does it accept zero ROI values at Init and modifies them internally to min supported ROI rects (like Query does)

Yes.

@eistarov , can you please comment? Is it correct behavior?

[eistarov]

• does it accept zero ROI values at Init and modifies them internally to min supported ROI rects (like Query does)

Yes.

@eistarov , can you please comment? Is it correct behavior?

I think, correct behavior would be to consider zero-rects as valid at Query and ignore at Init/run-time. Exception for Query required only due to "special" max supported NumROI report mechanic:

The Query function mode 2 returns maximum supported value (set it to 256 and Query will update it to maximum supported value).

[dmitryermilov]

• does it accept zero ROI values at Init and modifies them internally to min supported ROI rects (like Query does)

Yes.

@eistarov , can you please comment? Is it correct behavior?

I think, correct behavior would be to consider zero-rects as valid at Query and ignore at Init/run-time. Exception for Query required only due to "special" max supported NumROI report mechanic:
The Query function mode 2 returns maximum supported value (set it to 256 and Query will update it to maximum supported value).

Thanks @eistarov !