Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

allow ROI rectangle top/left/bottom/right to be 0 for query #2013

Open
guoyejun opened this issue Mar 14, 2020 · 7 comments · Fixed by #2480 · May be fixed by #2487 or #2907
Open

allow ROI rectangle top/left/bottom/right to be 0 for query #2013

guoyejun opened this issue Mar 14, 2020 · 7 comments · Fixed by #2480 · May be fixed by #2487 or #2907
Assignees
@DenWolf @lakulako @vilichev @yskuridi
Labels
AVCe HEVCe

Comments

@guoyejun
Copy link
Contributor

i submitted a PR #1856 for this issue, and after discussion, i hoped to pass the ball back to msdk team.

I just checked the latest code and found that we still need to set a non-empty rectangle for the query, so file this issue to check it. Hope it can be resolved before next release, thanks.
@guoyejun
Copy link
Contributor Author

any update? thanks.

@guoyejun
Copy link
Contributor Author

any update? thanks

@daleksan
Copy link
Contributor

@vilichev please follow up

@vilichev
Copy link
Contributor

@yskuridi Please investigate

@yskuridi
Copy link
Contributor

yskuridi commented Nov 9, 2020

proposed a solution.
waiting for confirmation from architects

@dmitryermilov
Copy link
Contributor

Dear @guoyejun ,

Sorry for delay. We're discussed internally. The plan is the following:
Per the msdk manual, Query shall return max number of supported ROI if app passes 256 to input params:
NumROI - Number of ROI descriptions in array. The Query function mode 2 returns maximum supported value (set it to 256 and Query will update it to maximum supported value).

But currently AVC and HEVC encoders treats zero size rect's as error. We'll fix it. Query will fill rect sizes with min supported sizes.

@yskuridi , could you implement a fix?

@yskuridi yskuridi mentioned this issue Nov 13, 2020
Merged
yskuridi added a commit to yskuridi/MediaSDK that referenced this issue Nov 13, 2020
@yskuridi
[hevce] Expand zero ROI to minimum supported size
a0f3e7a 
Fixes Intel-Media-SDK#2013.
Change (0 0 0 0) ROIs instead of removing them.
dmitryermilov pushed a commit that referenced this issue Nov 16, 2020
@yskuridi @dmitryermilov
[hevce] Expand zero ROI to minimum supported size
48c64a9 
Fixes #2013.
Change (0 0 0 0) ROIs instead of removing them.
@dmitryermilov
Copy link
Contributor

Commit above fixes HEVC. We need to fix AVC as well. So re-opening

@dmitryermilov dmitryermilov reopened this Nov 16, 2020
dmitryermilov added a commit to dmitryermilov/MediaSDK that referenced this issue Nov 16, 2020
@dmitryermilov
[avce] Expand zero ROI to minimum supported size
6f8dbc0 
Fixes: Intel-Media-SDK#2013

Signed-off-by: Dmitry Ermilov <[email protected]>
@dmitryermilov dmitryermilov linked a pull request Nov 16, 2020 that will close this issue
Open
@daleksan daleksan added the AVCe label Jun 9, 2021
@kovakimy kovakimy linked a pull request Mar 10, 2022 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DenWolf DenWolf

@lakulako lakulako

@vilichev vilichev

@yskuridi yskuridi

Labels
AVCe HEVCe
Projects
None yet
Milestone
No milestone
8 participants
@guoyejun @dmitryermilov @daleksan @DenWolf @lakulako @vilichev @saosipov @yskuridi