Add support for regions customValues #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garronej
reviewed
Dec 16, 2023
|
Nice! Thanks a lot! |
This feature was introduced in onyxia-api in PR 298 ( InseeFrLab/onyxia-api#298). Values from onyxia api configuration (regions.json -> services.customValues) are available to use in helm templates as region.customValues Co-authored-by: garronej <[email protected]>
johnksv
force-pushed
the
add-support-custom-values
branch
from
35748a8 to
869f4ec
Compare
|
Thank you for review. I have implemented and tested your changes and forced push the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom values can be defined in onyxia-api. This feature was introduced in onyxia-api in PR InseeFrLab/onyxia-api#298 .
This PR does such that these values can be used in the helm templates. They will be available as region.customValues. in helm templates.