Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arbitrary Helm list parameter injection in GET /my-lab/app #540

Merged

Conversation

nicolst
Copy link
Contributor

@nicolst nicolst commented Dec 18, 2024

Helm release names need to be 53 characters or less and be valid RFC1123 strings, so this will throw an exception (resulting in a 500 error) if anything else is provided

@fcomte fcomte merged commit 94f32e3 into InseeFrLab:main Dec 18, 2024
6 checks passed
@nicolst nicolst deleted the fix/arbitrary-helm-arguments branch December 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants