Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement refresh endpoint (as an admin endpoint) #522

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Implement refresh endpoint (as an admin endpoint) #522

merged 5 commits into from
Nov 22, 2024

Conversation

skykanin
Copy link
Contributor

No description provided.

@skykanin
Copy link
Contributor Author

don't merge this yet, I still want to explore implementing unit tests for this

@olevitt olevitt changed the title implement refresh endpoint Implement refresh endpoint (as an admin endpoint) Nov 21, 2024
olevitt
olevitt requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, there is just an oversight in the default configuration

onyxia-api/src/main/resources/application.properties Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@olevitt olevitt self-requested a review November 22, 2024 07:39
olevitt
olevitt approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you ! 👍

@olevitt olevitt merged commit 23bb178 into InseeFrLab:main Nov 22, 2024
1 check passed
@skykanin skykanin deleted the add-refresh-endpoint branch November 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevitt olevitt olevitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skykanin @olevitt