Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint and code factorisation #154

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Pylint and code factorisation #154

merged 3 commits into from
Feb 7, 2024

Conversation

bclenet
Copy link
Collaborator

@bclenet bclenet commented Feb 6, 2024

Changes proposed in this Pull Request:

  • linted the code so that the code_quality check continues to pass
  • including the narps_open/pipelines to pylint checks, some in-file ignores are left
  • solved the output naming bug (output names containing { after formatting fail) for all pipelines

Checklist:

  • Descriptive title
  • Targets the main branch
  • Changes are functional
  • My code is explicit and comments were added to it
  • Code conforms with PEP8
  • Tests were added for the changes and they complete successfully
  • Existing tests were updated (if needed) and they complete successfully
  • Documentation was updated

@bclenet bclenet requested a review from a team as a code owner February 6, 2024 14:25
@bclenet bclenet merged commit d1fb492 into Inria-Empenn:main Feb 7, 2024
6 of 7 checks passed
@bclenet bclenet deleted the pylint branch February 7, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bclenet