Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C88N refactoring #116

Merged
merged 39 commits into from
Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
40abccc
[REFAC] make C88N conform with the Pipeline class + PEP8 clean
bclenet Mar 27, 2023
eabf700
[BUG] typo in dir names
bclenet Apr 7, 2023
d019195
[TEST] making paths consistent in pipeline test execution [skip ci]
bclenet Apr 7, 2023
9903f35
Using the right contrast ids
bclenet Apr 12, 2023
8db2006
Using the right contrast ids
bclenet Apr 12, 2023
7c6e160
[BUG] in ci script for pipeline changes
bclenet Mar 27, 2023
af995cb
[BUG] correctly forming results download link
bclenet Apr 7, 2023
6a74494
Allowing to tweak the number of processes the runner uses
bclenet Apr 12, 2023
da8a9fa
[ENH] Allowing to run group and subject level independantly
bclenet Apr 12, 2023
45a64c2
[TEST] test the runner launching first level or second level only
bclenet Apr 17, 2023
b705960
[DOC] runner : allow to run levels separately
bclenet Apr 18, 2023
6986e90
[BUG] inside unit_tests workflow
bclenet Aug 31, 2023
d6e67f3
Merge branch 'Inria-Empenn:main' into main
bclenet Aug 31, 2023
c3bfc53
Merge branch 'Inria-Empenn:main' into main
bclenet Sep 4, 2023
4b30504
Merge branch 'Inria-Empenn:main' into main
bclenet Sep 19, 2023
fd15ffc
Merge branch 'Inria-Empenn:main' into main
bclenet Sep 21, 2023
6ebe5d2
Merge branch 'Inria-Empenn:main' into main
bclenet Sep 29, 2023
0a584dd
Merge branch 'Inria-Empenn:main' into main
bclenet Sep 29, 2023
e284b80
Merge branch 'Inria-Empenn:main' into main
bclenet Sep 29, 2023
1a34af5
Merge branch 'main' into c88n_refac
bclenet Sep 29, 2023
25f881c
Pipeline refac after merge
bclenet Sep 29, 2023
64127b9
Refac pipeline
bclenet Oct 2, 2023
9b9b646
[TEST] rewrite test file + bugs in pipeline file
bclenet Oct 3, 2023
e513308
Codespell
bclenet Oct 3, 2023
5774813
Merge branch 'Inria-Empenn:main' into main
bclenet Oct 5, 2023
8f12d3d
Merge branch 'Inria-Empenn:main' into main
bclenet Oct 5, 2023
91dc744
Merge branch 'Inria-Empenn:main' into main
bclenet Oct 10, 2023
c03e9d1
Merge branch 'Inria-Empenn:main' into main
bclenet Nov 20, 2023
fe0d25b
Merge branch 'Inria-Empenn:main' into main
bclenet Nov 22, 2023
04d5ff2
Merge branch 'Inria-Empenn:main' into main
bclenet Nov 22, 2023
f557d8e
Merge branch 'main' into c88n_refac [skip ci]
bclenet Jan 2, 2024
8aed13e
[REFAC] C88N [skip ci]
bclenet Jan 2, 2024
bc08911
[REFAC] using narps_open.core for contrast files selection [TEST] upd…
bclenet Jan 3, 2024
9645b7b
Issue with base directory [skip ci]
bclenet Jan 3, 2024
b607dc1
Back to the right order of contrasts [skip ci]
bclenet Jan 3, 2024
a79126c
[REFAC] naming [skip ci]
bclenet Jan 3, 2024
ac87fd9
Issue with groupComp [skip ci]
bclenet Jan 4, 2024
6bf8336
[BUG] subject ids in search patterns [skip ci]
bclenet Jan 4, 2024
4ec7dfe
Remove unwanted graphs[skip ci]
bclenet Jan 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion narps_open/pipelines/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
'B23O': None,
'B5I6': None,
'C22U': None,
'C88N': None,
'C88N': 'PipelineTeamC88N',
'DC61': None,
'E3B6': None,
'E6R3': None,
Expand Down
12 changes: 5 additions & 7 deletions narps_open/pipelines/team_2T6S.py
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ def get_group_level_analysis_sub_workflow(self, method):
height_threshold = 0.001, height_threshold_type = 'p-value',
force_activation = True),
name = 'threshold', iterfield = ['stat_image', 'contrast_index'])
threshold.synchronize = True

l2_analysis = Workflow(
base_dir = self.directories.working_dir,
Expand All @@ -512,7 +513,8 @@ def get_group_level_analysis_sub_workflow(self, method):
(selectfiles_groupanalysis, sub_contrasts, [
('contrast', 'file_list'),
('participants', 'participants_file')]),
(estimate_model, estimate_contrast, [('spm_mat_file', 'spm_mat_file'),
(estimate_model, estimate_contrast, [
('spm_mat_file', 'spm_mat_file'),
('residual_image', 'residual_image'),
('beta_images', 'beta_images')]),
(estimate_contrast, threshold, [('spm_mat_file', 'spm_mat_file'),
Expand All @@ -528,11 +530,9 @@ def get_group_level_analysis_sub_workflow(self, method):

if method in ('equalRange', 'equalIndifference'):
contrasts = [('Group', 'T', ['mean'], [1]), ('Group', 'T', ['mean'], [-1])]

threshold.inputs.contrast_index = [1, 2]
threshold.synchronize = True

## Specify design matrix
# Specify design matrix
one_sample_t_test_design = Node(OneSampleTTestDesign(),
name = 'one_sample_t_test_design')

Expand All @@ -543,11 +543,9 @@ def get_group_level_analysis_sub_workflow(self, method):
elif method == 'groupComp':
contrasts = [
('Eq range vs Eq indiff in loss', 'T', ['Group_{1}', 'Group_{2}'], [-1, 1])]

threshold.inputs.contrast_index = [1]
threshold.synchronize = True

# Node for the design matrix
# Specify design matrix
two_sample_t_test_design = Node(TwoSampleTTestDesign(),
name = 'two_sample_t_test_design')

Expand Down
Loading