Skip to content

Commit

Permalink
Q6O0 reproduction (#68)
Browse files Browse the repository at this point in the history
* [Q6O0] refactoring pipeline

* [Q6O0] updating list of implemented pipelines

* [TEST] change implemented pipeline test

* [CI] code quality change

* [CI] code quality change

* [CI] record pylint logs in case of failure only

* [CI] install whole package before linting

* [CI] adding higher timeouts to self-hosted jobs

* [BUG] adding inputs to subject info node

* [BUG] changes in pipeline workflow

* [BUG] unnecessary commented line in pipeline

* [REFAC] remove distance as unused in model design

* [TEST] init a test for conftest.py

* [BUG] inside unit_tests workflow

* [TEST] testing the conftest module

* Issue with parameters dir creation

* Bug with makedirs import

* [TEST] sorting results before computing correlations
  • Loading branch information
bclenet authored Sep 26, 2023
1 parent 2589123 commit 2fa3a0d
Show file tree
Hide file tree
Showing 8 changed files with 798 additions and 650 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ on:
push:
paths:
- '**.py'
- '.github/workflows/code_quality.yml'
pull_request:
paths:
- '**.py'
- '.github/workflows/code_quality.yml'

# Jobs that define the workflow
jobs:
Expand All @@ -33,22 +35,23 @@ jobs:
- uses: actions/cache@v3
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-pylint
key: ${{ runner.os }}-pip-${{ hashFiles('setup.py') }}
restore-keys: |
${{ runner.os }}-pip-pylint
${{ runner.os }}-pip-
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pylint
pip install .[tests]
- name: Analyse the code with pylint
run: |
pylint --exit-zero narps_open > pylint_report_narps_open.txt
pylint --exit-zero tests > pylint_report_tests.txt
pylint --fail-under 8 --ignore-paths narps_open/pipelines/ narps_open > pylint_report_narps_open.txt
pylint --fail-under 8 tests > pylint_report_tests.txt
- name: Archive pylint results
uses: actions/upload-artifact@v3
if: failure() # Only if previous step failed
with:
name: pylint-reports-python
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pipeline_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
echo "tests=$test_files" >> $GITHUB_OUTPUT
echo "teams=$teams" >> $GITHUB_OUTPUT
# A job to identify and run the tests
# A job to run the tests
pytest:
needs: identify-tests
runs-on: self-hosted
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
echo $test_files
echo "tests=$test_files" >> $GITHUB_OUTPUT
# A job to list the tests to be run
# A job to run the tests
pytest:
needs: identify-tests
runs-on: self-hosted
Expand Down
2 changes: 1 addition & 1 deletion narps_open/pipelines/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
'O6R6': None,
'P5F3': None,
'Q58J': None,
'Q6O0': None,
'Q6O0': 'PipelineTeamQ6O0',
'R42Q': None,
'R5K7': None,
'R7D1': None,
Expand Down
Loading

0 comments on commit 2fa3a0d

Please sign in to comment.