-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to convert a tracks file to a density map #114
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks to port Thomas' work in anima.
Can you statisfy "request changes" please.
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx
Outdated
Show resolved
Hide resolved
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx
Outdated
Show resolved
Hide resolved
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx
Outdated
Show resolved
Hide resolved
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx
Outdated
Show resolved
Hide resolved
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks to port Thomas' work in anima.
Can you statisfy "request changes" please.
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx
Outdated
Show resolved
Hide resolved
@Florent2305 I modified the main algorithm to compute the density map, because it seems to me that Thomas Durantel's implementation has drawbacks. In this new implementation, the sgn function is no longer used, and neither is the dist variable, so these change requests no longer apply. Could you please have a look at this new implementation of the main algorithm, and tell me if there are parts to modify? |
@Gregoire-V Are you using this PR to push the most recent developed tool? |
Yes! I talked about it with Florent yesterday and I will soon do a new commit with several changes. |
This merge to put image_to_mask feature inside ShapeToDensityFeature branch, to avoid conflicts later on.
…de a file animaFibersCounter_fusion.cxx + delete previous animaFibersCounter.cxx and shapes_to_density folder
Thanks for the work @Gregoire-V ! Let me know when this is ready for review. |
…ntation convention change.
In the binary, I added a switch argument -N that deactivates the computation of interpolation points (when two consecutive track points are separated by more than the voxel size). This enables more compatibility with the previous anima binary. However, even with this option activated, the behavior will be slightly different, since in this new binary and unlike the previous one, if a track has several points in the same voxel, we will count it once for this voxel and not [number of points] times. |
Code is ready for review! |
Written by Thomas Durantel @todurante.