Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.7] polygonroi shift-click + remove contour #872

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mathildemerle
Copy link

Mini release 4.0.7 following tests by radio operators. There will be other PR.

When PolygonROI toolbox have been partially changed with multi view and shift click to draw, and then that the multi view have been removed, shift click stayed. We removed this shift click because radio operators did not like the functionality. Then they retested and a deactivate/reactivate drawing button to deactivate PolygonROI have been removed due to the changes done in PolyronROI, that is still missing. It's important to be able to change the contrast or zoom during the drawing. So, they prefer to use shift click, or to have the button back. This PR adds back the shift click.

Also, there was a bug when you removed the last node/contour with right-click -> remove. The current default label needed to be reclicked/selected.

Ⓜ️

@mathildemerle mathildemerle added this to the v4.0 milestone Jan 13, 2025
@mathildemerle
Copy link
Author

I updated the release notes for https://github.com/Inria-Asclepios/music/pull/1100
And also, VoiCutter processOutput() method do not need to add the data name suffix (metadata are already updated at that time in output data, and this line crash sometimes).

@mathildemerle mathildemerle merged commit 8f9bae0 into Inria-Asclepios:master Jan 16, 2025
1 check failed
@mathildemerle mathildemerle deleted the temp4.0.7 branch January 16, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants