Skip to content
This repository has been archived by the owner on Mar 30, 2020. It is now read-only.

Itk5threading #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

dzenanz
Copy link

@dzenanz dzenanz commented Jul 20, 2018

No description provided.

Jon Haitz Legarreta and others added 6 commits April 14, 2018 19:27
Move `ITK_DISALLOW_COPY_AND_ASSIGN` calls to public section following
the discussion in
https://discourse.itk.org/t/noncopyable

If legacy (pre-macro) copy and assing methods existed, subsitute them
for the `ITK_DISALLOW_COPY_AND_ASSIGN` macro.

Fix class name in `ITK_DISALLOW_COPY_AND_ASSIGN` macro declaration
argument for class `itk::GPUSmoothingRecursiveYvvGaussianImageFilter`:

`GPUSmoothingecursiveYvvGaussianImageFilter`
to
`GPUSmoothingeRecursiveYvvGaussianImageFilter`
…YANDASSIGNToPublicSection

COMP: Move ITK_DISALLOW_COPY_AND_ASSIGN calls to public section.
@hjmjohnson
Copy link
Contributor

@dzenanz This PR need work for getting it upstream. It seems that ITK and this version have diverged.

@dzenanz
Copy link
Author

dzenanz commented Nov 5, 2018

It looks like there has been no activity in this repository since February. We should probably make this fork the main one. @thewtex @jhlegarreta @blowekamp

I need to work on other projects next 2-3 weeks, I will review code etc during that time but I will not make major contributions. I plan to get back to ITK in late November. If this can wait until then, I will work on it. If not, somebody else needs to pick it up.

@hjmjohnson
Copy link
Contributor

See InsightSoftwareConsortium#6 (comment)

There is general agreement that we should make this the primary and remove the fork to upstream.

@jhlegarreta
Copy link

Yes, as Hans has pointed, making the ISC fork the main repo for this remote was commented some time ago, and Tom has recently reaffirmed on this.

Many of the commits in this PR have already been merged to the ISC fork (e.g. this one), and a PR was submitted to the ISC fork to solve the divergence.

@hjmjohnson
Copy link
Contributor

Closing due to lack of updates. The InsightSoftwareConsortium version has these changes.

@hjmjohnson
Copy link
Contributor

Wrong repo. This repo could be archived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants