Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch_size parameter for predict() and cli #83

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

johnbradley
Copy link
Collaborator

Adds --batch-size for predict command.
Adds batch_size to classifier predict() function.
Default batch size is 10.
Updates early notebooks to process images in a batch.

Fixes #80

@johnbradley johnbradley requested a review from Copilot January 31, 2025 15:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • examples/PredictImages.ipynb: Evaluated as low risk
Comments suppressed due to low confidence (1)

tests/test_predict.py:1

  • Missing import for torch and EXAMPLE_CAT_IMAGE, EXAMPLE_CAT_IMAGE2. Add these imports to avoid import errors.
import unittest

tests/test_predict.py Show resolved Hide resolved
tests/test_predict.py Show resolved Hide resolved
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Adds --batch-size for predict command.
Adds batch_size to classifier predict() function.
Default batch size is 10.
Updates early notebooks to process images in a batch.

Fixes #80
@johnbradley johnbradley merged commit 306a0be into main Feb 5, 2025
2 checks passed
@johnbradley johnbradley deleted the 80-progress-bar branch February 5, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Progress Bar
3 participants