-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for skunk #192
Conversation
Not sure this is the good way of doing things, if I try the case class example with implicit conversions: // defining a codec for a refined case class
final case class User(name: Username, age: Int :| Positive)
given Codec[User] = (varchar *: int4).to[User] Compilation fails with a compiler crash:
|
What is the full error thrown by the compiler? |
The test module, including this part: // defining a codec for a refined case class
final case class User(name: Username, age: Int :| Positive)
given Codec[User] = (varchar.refined[Not[Blank]] *: int4.refined[Positive]).to[User] seems to compile and work as expected. Am I missing something? EDIT: Nevermind, I found the difference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. I just think the introduced implicit conversion is not necessary and causes more issues (e.g the compiler crash) than benefits.
Adds support for Skunk.