Enhance select element

[sukhwinder33445]

Blocked by

• Add DeferredInArrayValidator ipl-validator#12
• SelectOption: Add method getLabel() and change method setLabel() #70

fixes #84

TODO:

• Fix that test testSelectingDisabledOptionIsNotPossible() fails because of cached isValid().

[lippserd]

Since you are adjusting the entire class, please define the proper arguments and return types for all methods the class provides itself.

[lippserd]

1. Please document the trait.
2. Please test the trait.
3. Don't drop ZF1 compatibility yet. I haven't checked if any of this applies to IPL forms, but I wouldn't bother to check either. The separate PR was fine.
4. The whole logic for disabling options is questionable as it is not possible to control this via construct time attributes and option groups cannot be disabled or the entire element (which effectively means all options (and groups) are automatically disabled). And the funniest thing is, it's not used at all, see here, here, here and here. So we have a semi-implemented feature that is not used at all and just presents complexity for further changes. I would remove the ability to disable options.
5. And while we're removing stuff anyway, please drop deselect(). Also not used.

Update:

4. I would remove the ability to disable options.

This applies to the methods in the form, since $form->getOption()->setAttribute('disabled', true) can always be called. Note that validation must still take disabled attributes into account. Your current changes would no longer do that for the above call. Please add a test for this as well.

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @sukhwinder33445

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[sukhwinder33445]

@cla-bot check

outdated