ObjectSuggestions: Don't apply base filter to $customVars query #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix/object-customvar-suggestions
branch
from
5adb282 to
b7e8c20
Compare
sukhwinder33445
force-pushed
the
fix/object-suggestion-for-customVars
branch
from
4dc7a58 to
5803461
Compare
sukhwinder33445
force-pushed
the
fix/object-customvar-suggestions
branch
2 times, most recently
from
c445235 to
f7e2c4c
Compare
sukhwinder33445
force-pushed
the
fix/object-suggestion-for-customVars
branch
from
5803461 to
05992b1
Compare
nilmerg
force-pushed
the
fix/object-customvar-suggestions
branch
from
f7e2c4c to
2e0ed59
Compare
Base automatically changed from
fix/object-customvar-suggestions
to
dependencies
January 20, 2025 09:54
nilmerg
requested changes
Jan 20, 2025
The basefilter may contain relations, that are not know to `CustomvarFlat`, which can leads to errors.
For example: RedundancygroupController:completeActions's base filter is not known to `CustomvarFlat`.
sukhwinder33445
force-pushed
the
fix/object-suggestion-for-customVars
branch
from
05992b1 to
e9970dc
Compare
nilmerg
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: #1100
CustomvarFlat, which can leads to errors.For example:
RedundancygroupController:completeAction's base filter ((parent|child).redundancy_group.id)) is not known toCustomvarFlat.