Dev Commit | Preview Release 1.8.726.5

[ PREVIEW BUILD | NOT FINAL ]

Build HASH: 38CB64C4AB770F4D0C8C2C579DC85340

NOTE:

This build is not final, Expect few bugs

- Any AV detection is false positive as I submitted the file to Microsoft
![image](https://github.com/IchimakiKasura/CeeleLauncher/assets/80595346/cb7852d8-aa7d-403b-b0e4-2242286351fd)

	The file keeps detecting it as a Wacatac when the build fails but when the build has no errors there's no Wacatac detected. The code will be refactored soon to find the problem.

This Preview release of 1.8.x might be the last because I barely notice any bugs after testing and fixing it for 2 months so expect sooner or later an Official release will be uploaded.

FIXES ON THIS BUILD:
- Fixed MessageBox closing animation not playing.
- Fixed Launcher button being bugged out.
- Fixed MessageBox Owned windows being null on the start.
making Unowned windows not appear on taskbars.
- Fixed App crashing if the game directory is on a non-existing drive letter.
- Fixed where Resetting the settings Crashes the app.
- Fixed Location textbox focus outline when tabbed.

src/HoyoLauncher.Controls/TopButtons/TopButtonIcons.xaml.cs

@@ -50,4 +50,4 @@ protected virtual void OnClicked(RoutedEventArgs Event) =>
 
     private void Clicked(object s, RoutedEventArgs Event) =>
         OnClicked(Event);
-}
+}

src/HoyoLauncher.Core/Config/MainConfig.cs

@@ -135,6 +135,7 @@ public static async Task<MainConfig> ReadConfig()
             ERROR("CONFIG ERROR", x.Message);
             return null;
         }
+
     }
 
     /// <summary>

src/HoyoLauncher.Core/HoyoMain.cs

@@ -30,8 +30,8 @@ public static async void Initialize()
         if (!App.Config.CHECKBOX_BACKGROUND)
             HoyoWindow.MediaElementBG.Source = null;
 
-        if(App.Config.CUSTOM_BACKGROUND is not "" or null)
-            HoyoWindow.MainBG.Background = DefaultBG.DEFAULT = new(new BitmapImage(new(App.Config.CUSTOM_BACKGROUND)))
+        if(File.Exists(App.Config.CUSTOM_BACKGROUND))
+            HoyoWindow.MainBG.Background = DefaultBG.DEFAULT = new(new BitmapImage(new(App.Config.CUSTOM_BACKGROUND, UriKind.RelativeOrAbsolute)))
             {
                 Stretch = Stretch.UniformToFill
             };

src/HoyoLauncher.csproj

@@ -30,6 +30,7 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="$(Configuration) == Release Or $(Configuration) == Preview">
+        <Optimize>True</Optimize>
         <ProduceReferenceAssembly>False</ProduceReferenceAssembly>
         <RuntimeIdentifier>win-x64</RuntimeIdentifier>
         <PublishProtocol>FileSystem</PublishProtocol>
@@ -39,7 +40,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\ini-reader\src\IniParser\IniParser.csproj"/>
+      <ProjectReference Include="..\ini-reader\src\IniParser\IniParser.csproj" />
     </ItemGroup>
 
     <!-- Resources -->

src/HoyoLauncherSettings/HoyoSettings.xaml.cs

@@ -65,8 +65,8 @@ protected override void OnClosed(EventArgs e)
 
     static void RefreshCurrentSelectedGame()
     {
-        if (App.Config.CUSTOM_BACKGROUND is not "" or null)
-            DefaultBG.DEFAULT = new(new BitmapImage(new(App.Config.CUSTOM_BACKGROUND)))
+        if (File.Exists(App.Config.CUSTOM_BACKGROUND))
+            DefaultBG.DEFAULT = new(new BitmapImage(new(App.Config.CUSTOM_BACKGROUND, UriKind.RelativeOrAbsolute)))
             {
                 Stretch = Stretch.UniformToFill
             };

src/HoyoLauncherSettings/SettingsButtonEvents/LocateLocationButton.cs

@@ -4,8 +4,8 @@ public partial class HoyoSettings
 {
     void LocationButtonClick(object s, RoutedEventArgs e)
     {
-        using var Folder = new Forms.FolderBrowserDialog();
         e.Handled = true;
+        var Folder = new Forms.FolderBrowserDialog();
 
         if (Folder.ShowDialog() is Forms.DialogResult.Cancel) return;
 
@@ -21,14 +21,15 @@ void LocationButtonClick(object s, RoutedEventArgs e)
 
     void LocationImageButtonClick(object s, RoutedEventArgs e)
     {
+        e.Handled = true;
+
         var ImageFile = new Microsoft.Win32.OpenFileDialog
         {
             Filter = "PNG|*.png|JPG|*.jpg;*.jpeg|GIF|*.gif|BMP|*.bmp|All Files|*.*"
         };
-        e.Handled = true;
 
         if (ImageFile.ShowDialog() is false) return;
 
         BG_DIR_TXT.Text = App.Config.CUSTOM_BACKGROUND = ImageFile.FileName;
     }
-}   
+}

src/MainWindow.xaml.cs

@@ -3,7 +3,10 @@
 // It was supposed to be a simple launcher that opens the game,
 // why do i need to go as far as detecting a new version, downloading the new version and even pre-installing the upcoming version.
 // what the fuck am i doing?
-
+//
+// NOTE TO MYSELF:
+//      Refactor the code if possible since publishing the file on first try causes GenerateBundle Task error
+//      when multiple error on publish build was ran, a "Wacatac" will be detected for no reason causing AV to be alerted.
 public partial class MainWindow : Window
 {
     [StaticWindow]

src/ShorTour.xaml.cs

@@ -58,4 +58,4 @@ protected override void OnClosed(EventArgs e)
         HoyoWindow.BLACK_THING.Visibility = Visibility.Collapsed;
         base.OnClosed(e);
     }
-}
+}