-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESSI-875] bulkrax 5 upgrade #597
Open
aploshay
wants to merge
30
commits into
main
Choose a base branch
from
essi-875_bulkrax_upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56c76ad
to
ba932fb
Compare
c49692b
to
1f429a5
Compare
1f429a5
to
ce0d8f0
Compare
fa7d845
to
c7f5a90
Compare
dlpierce
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good by visual inspection.
The downgrade of sidekiq is probably a good thing. While nothing seemed broken, it does warn that sidekiq 7 is not supported on this old stack.
…et-specific metadata
ae98c43
to
2df1729
Compare
dlpierce
approved these changes
Jan 15, 2025
891b235
to
c247f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades from bulkrax 1.0.2 to 5.5.1.
Work and FileSet ingest is working in my local environment, with some outstanding issues.
Known Issues:
FileSet <-> Work association**: The various import jobs aren't being sequenced to run in the necessary order (at least, in my local environment), so I'm finding I have to run the importer once to get the works created (with all the FileSets failing), then re-run it to create all the FileSets. See[bulkrax issue #955](importer tries, fails to create FileSets before Works are persisted (tested in 5.5.1, 7.0.0) samvera/bulkrax#955)~Collection creation/association**: I haven't had success ingesting to create a new Collection, or to associate to an existing one -- but I only tried this lightly, and it might be issues of configuration and/or CSV content.but with access concerns, access restricted to admins and managers, and file export prevented (isn't working, and we don't want it done, anyway)Temporarily skipped tests:
Regarding
configuration change
label:Notes on running locally: