-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues #3 and #5 🎟️: Waving Alien when form submitted (Contact Page) and JSR Assess changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new waving alien icon when form is successfully submitted. - Update 'message' regex to allow white space characters. - Update all inputs placeholder text to be more descriptive. - Disable submit button when form has been successfully submitted. - Conditionally render the new waving alien icon when form has been successfully submitted.
- Add the following dependencies to the useEffect starting at lines: - 'updateFormContent' => line 107. - 'validateInput' => line 119. - 'hideInputs' => line 167. - 'validInputsPattern' and 'validateInput' => line 208. - useCallback hook to the following functions: - 'updateFormContent'. - 'validateInput'. - 'hideInputs'. - This changes will prevent the re-renders at the 'ContactForm' component.
…t 'ContactPage.scss'
ITurres
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
UI/UX
redeploy
gh-pages deployment
labels
Feb 7, 2024
This was
linked to
issues
Feb 7, 2024
ITurres
commented
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug fix
fixed a bug
documentation
Improvements or additions to documentation
enhancement
New feature or request
redeploy
gh-pages deployment
UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary for Issue #3 and #5 Completion
Overview:
Issue [2pt] Waving Alien when form submitted (Contact Page) #3
Issue [4pt] Assess portfolio for JSR - follow rubric #5
Changes Made:
Added:
.github/workflows/deploy.yml
.github/workflows
directory for the gh-pages deployment to pick up the environment variables from the repository's secrets./public/apple-touch-icon.png
Modified:
/README.md
/public/index.html
'/public/manifest.json'
/src/components/UI/ContactForm.tsx
Thank you!
button now has a waving alien gif that will be displayed once the form has been successfully submitted.>>bug fix<<
Now the submit button will be disabled once the form has been successfully submitted to prevent multiple submissions./src/components/UI/LikeButton.tsx
/src/components/pages/AboutPage.tsx
Link
component that will redirect the user to the contact page./src/components/pages/ContactPage.tsx
/src/db/expertiseSummary.json
/src/styles/UI/LikeButton.scss
/src/styles/UI/ContactForm.scss
/src/styles/UI/LineCount.scss
.line-count
class properties were moved out of the ampersand selector to simplify the structure and improve readability since this was unnecessary./src/styles/pages/AboutPage.scss
/src/styles/pages/ContactPage.scss
/src/styles/pages/ExpertiseSummaryPage.scss
Reasoning:
Thank you!
button to give the user a sense of completion and satisfaction once the form has been successfully submitted.Impact:
Testing:
Related Issues:
Dependencies:
Additional Notes: