-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Computational backend: passing labels and envs 🗃️ #4429
✨Computational backend: passing labels and envs 🗃️ #4429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4429 +/- ##
========================================
+ Coverage 84.6% 86.0% +1.3%
========================================
Files 1010 899 -111
Lines 43115 39642 -3473
Branches 1016 587 -429
========================================
- Hits 36493 34095 -2398
+ Misses 6401 5409 -992
+ Partials 221 138 -83
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fc00543
to
dd65c83
Compare
Please retry analysis of this Pull-Request directly on SonarCloud. |
6d7184d
to
e12bb89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 !
packages/models-library/src/models_library/service_settings_labels.py
Outdated
Show resolved
Hide resolved
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/docker_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/models.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/director_v2/_handlers.py
Show resolved
Hide resolved
9d46c5d
to
e436cdd
Compare
4843f6c
to
f9fdf13
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks 👍 I merged a DB migration few minutes ago, probably you need to change the DB migration id
4e2dd5a
to
47dd9dc
Compare
Code Climate has analyzed commit 47dd9dc and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
@matusdrobuliak66 the limits will come in a different PR: #4453
I need to do some changes to the naming of these labels because
_
are not valid docker label keys. I will have to change these.Related issue/s
How to test
DevOps Checklist