-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rob/mdanse trajectory filter #615
base: protos
Are you sure you want to change the base?
Conversation
MDANSE/Src/MDANSE/Framework/Configurators/TrajectoryFilterConfigurator.py
Outdated
Show resolved
Hide resolved
a042cee
to
f3df3b0
Compare
b24005c
to
41b0d3e
Compare
MDANSE/Src/MDANSE/Framework/Configurators/TrajectoryFilterConfigurator.py
Outdated
Show resolved
Hide resolved
MDANSE/Src/MDANSE/Framework/Configurators/TrajectoryFilterConfigurator.py
Outdated
Show resolved
Hide resolved
settings_dict.update({setting: values["value"]}) | ||
return settings_dict | ||
|
||
_settings = filter_default_attributes.__func__(object()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing class-level properties and methods will probably cause confusion in future.
MDANSE/Src/MDANSE/Framework/Configurators/TrajectoryFilterConfigurator.py
Outdated
Show resolved
Hide resolved
MDANSE/Src/MDANSE/Framework/Configurators/TrajectoryFilterConfigurator.py
Outdated
Show resolved
Hide resolved
MDANSE_GUI/Src/MDANSE_GUI/InputWidgets/TrajectoryFilterWidget.py
Outdated
Show resolved
Hide resolved
if on: | ||
self.bound_freq_widget.setEnabled(True) | ||
return | ||
self.bound_freq_widget.setEnabled(False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if on: | |
self.bound_freq_widget.setEnabled(True) | |
return | |
self.bound_freq_widget.setEnabled(False) | |
self.bound_freq_widget.setEnabled(on) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact this function could just be:
toggle_bound_frequencies = self.bound_freq_widget.setEnabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change loses expected behaviour, tested on a bandpass filter which requires the frequency other bound to become enabled and it does not.
MDANSE_GUI/Src/MDANSE_GUI/InputWidgets/TrajectoryFilterWidget.py
Outdated
Show resolved
Hide resolved
MDANSE_GUI/Src/MDANSE_GUI/InputWidgets/TrajectoryFilterWidget.py
Outdated
Show resolved
Hide resolved
MDANSE_GUI/Src/MDANSE_GUI/InputWidgets/TrajectoryFilterWidget.py
Outdated
Show resolved
Hide resolved
…ydrogen) atomic trajectory csv data for testing
…tion of filter object
06784f2
to
f1ad3be
Compare
Description of work
TODO:
(Probably don't need to solve all of these immediately - some may become issues for further work after this is completed)
UI
UI &/or Backend
Backend
Tests
Other
Fixes
A list of fixes.
To test
Please describe the tests that were run to verify the changes.