Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 fix and removed NetCDF dependency #357

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

ChiCheng45
Copy link
Collaborator

Description of work
imp has been removed in python 3.12. This was used in the class registry. As the class registry is not really used I think we can just remove it. I've also removed the NetCDF dependency and some related code.

Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I have not found any problems with it.

@MBartkowiakSTFC MBartkowiakSTFC merged commit 329c1ac into protos Mar 15, 2024
84 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the chi/python-3-12-fix branch March 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants