Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom Properties speed-up in 3D view #347

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Atom Properties speed-up in 3D view #347

merged 7 commits into from
Mar 11, 2024

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
The atom property editor in the 3D view tab has been modified, and now it groups atoms of the same type into single entries. This allows the user to change the colour or size of all the atoms of the same type at once.

At the moment it is NOT possible to edit the properties of individual atoms anymore.

Also, at the same time check boxes have been added which enable or disable different parts of the 3D display (atoms, bonds, axes and cell).

Fixes

  • vtk arrays are now set using numpy_to_vtk helper functions, and not in a for loop.
  • there is only one entry per chemical element in the atom property editor.
  • bonds can be switched off (e.g. if detecting them takes too long).

To test

  1. Try toggling the checkboxes in 3D view both before and after selecting a trajectory.
  2. Edit the atom properties for different atom types and check if the display gets updated each time.

@ChiCheng45
Copy link
Collaborator

All work on my end but can we block the editing of the element name in the atom properties?

image

@MBartkowiakSTFC
Copy link
Collaborator Author

The atom name editing is now disabled.

@ChiCheng45
Copy link
Collaborator

ChiCheng45 commented Mar 11, 2024

The atom name editing is now disabled.

Thanks looks good!

@ChiCheng45 ChiCheng45 merged commit cbd8d7d into protos Mar 11, 2024
54 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the gui-atom-tree branch July 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants