Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trajectory tab and 3D view updates. #346

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Trajectory tab and 3D view updates. #346

merged 7 commits into from
Mar 8, 2024

Conversation

ChiCheng45
Copy link
Collaborator

Description of work

  • Improved the trajectory loading performance. 42,592 atoms can be loaded in a few seconds.
  • Added bonding to 3D view.
  • Added unit cell to 3D view.
  • Added method for faster access to atom database properties.
  • Updated trajectory panel so that they are not reloaded on trajectory selection change.
  • Optimized the build connectivity in MDANSE graph.

Animation12

To test
Load a few trajectories up in the trajectory tab and check 3D view is working correctly.

MBartkowiakSTFC
MBartkowiakSTFC approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I tried worked fine. It definitely works faster than the previous version.

@MBartkowiakSTFC MBartkowiakSTFC merged commit 39ce5cc into protos Mar 8, 2024
54 checks passed
@ChiCheng45 ChiCheng45 mentioned this pull request Mar 11, 2024
Closed
@ChiCheng45 ChiCheng45 deleted the chi/3d-view-bonding-update branch March 12, 2024 10:50
@ChiCheng45 ChiCheng45 linked an issue Mar 18, 2024 that may be closed by this pull request
[BUG] Trajectories with many atoms take too long to load #323
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBartkowiakSTFC MBartkowiakSTFC MBartkowiakSTFC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Trajectories with many atoms take too long to load
2 participants
@ChiCheng45 @MBartkowiakSTFC