Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved labels, corrected text output #345

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
This PR mainly deals with labels, docstrings and naming in MDANSE. Additionally, problems with analysis output in text format have been corrected so that text output works again.

Fixes

  1. Text output works again,
  2. Files in text output have correct creation time set,
  3. ASCIIFormat is now TextFormat,
  4. Renamed 'monoprocessor' and 'multiprocessor' to (more accurate) 'single-core' and 'multicore'.
  5. Added a docstring to RigidBodyTrajectory,
  6. Activated tooltips in the GUI for several widgets which were missing them before.

To test

  1. Load a trajectory,
  2. Check if all the action dialogs are created correctly. Look at the widget tooltips in some of the dialogs,
  3. Run an analysis using TextFormat as output,
  4. Check if the files in the resulting .tar archive are created correctly and with today's timestamp.

Copy link
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it works on my end. I added a commit so that there are new lines in some of the get information methods of the configurators so that the jobinfo.txt file is formatted nicely.

@ChiCheng45 ChiCheng45 merged commit 905aed1 into protos Mar 8, 2024
54 checks passed
@ChiCheng45 ChiCheng45 deleted the improved-labels branch March 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants