-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atom selection/filtering backend refactor #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructure_matches docstrings
…ert default string setting to fix unit tests
MBartkowiakSTFC
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes to the code. A definite improvement to the way we handle trajectory information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
The way that atom selection are done has now been changed. Previously a complicated parsing system was implemented which selected molecules based on a string which included set operations in it. I have simplified the approach so that it simply applies specific filters to remove specific atoms. This also makes the setting of the atom filtering more human json string e.g.
'{"water": true, "elements": {"S": true}}'
which will remove water molecules and sulfur atoms.FilterSelection settings can be updated with the
update_settings
method e.g.setting can be dumped to a json string with
settings_to_json
and updated with
update_from_json
.For molecule or molecular group filtering it now uses smarts pattern matching. This will make it much easier if we want to add matches for larger molecular groups or molecules. See the
select_water
function.To test
Run units tests to ensure passing, test GUI loads up without issues.