-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDANSE UnitTest fixes #277
Conversation
…projector test which doesn't exist anymore
…ow to (hopefully) fix ubuntu unit test failure
) | ||
self.assertTrue(np.allclose(com_trajectory, [[1.0, 1.0, 1.0]], rtol=1.0e-6)) | ||
self.assertTrue(np.allclose(com_trajectory, [[3.5, 3.5, 3.5]], rtol=1.0e-6)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a closer look at this part since the expected result has changed in this one, but it is clear that the new values are correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests that were supposed to pass really pass. Thank you working on it. The changes can be merged.
Description of work
Code changes to get all MDANSE UnitTest working and removed either redundant or obsolete test e.g. test which use MMTK.
Added github workflow to run tests.
Removed python 3.8 support since MDANSE uses newer python features that are not supported in 3.8.
Test under FunctionalTests directory to be fixed in a later pull request.
Cython code changes were made, recompilation of the Cython code will be required.
Fixes
Various fixes across the MDANSE codebase.
To test
Build and run MDANSE UnitTests with pytest.