Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set disable_pcon #405

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Set disable_pcon #405

merged 1 commit into from
Dec 9, 2024

Conversation

FreddieAkeroyd
Copy link
Member

Description of work

Disable pcon for better log file behaviour

To test

ISISComputingGroup/IBEX#8593

Acceptance criteria

List the acceptance criteria for the PR

Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@Tom-Willemsen Tom-Willemsen merged commit 4d9ad02 into master Dec 9, 2024
2 of 3 checks passed
@Tom-Willemsen Tom-Willemsen deleted the disable_pcon2 branch December 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Willemsen Tom-Willemsen Tom-Willemsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FreddieAkeroyd @Tom-Willemsen