Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mISDNcapid: honour --localstatedir when setting MISDN_CAPI_SOCKET_DIR #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mISDNcapid: honour --localstatedir when setting MISDN_CAPI_SOCKET_DIR #1

wants to merge 1 commit into from

Conversation

kristovschulz
Copy link
Contributor

Signed-off-by: Christoph Schulz [email protected]

@kkeil kkeil assigned kkeil and unassigned kkeil May 1, 2017
@kkeil kkeil added the bug label Jun 27, 2017
@kkeil
Copy link
Contributor

kkeil commented Jul 24, 2017 •
edited
Loading

This pull request is correct an fix a bug in the configure definition, but in the end it also discover a design flaw around the MISDN_CAPI_SOCKET_DIR define. Now the default case (no localstatedir set on the configure run) result in
#define MISDN_CAPI_SOCKET_DIR "${prefix}/run/mISDNcapid"
written in capi20/m_capi_sock.h, which will cause a runtime error later.
I did found no way to get autoconf to substitute "${prefix}" to the real PREFIX in this case.
Maybe to have an own --with-capisocketdir=DIR configure option default to "/run/mISDNcapid" could be a solution or is any auto config guru listening here and know how to get rid of the ${prefix} in this case ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kkeil kkeil

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristovschulz @kkeil